Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve XXE issue in validator #1530

Merged
merged 5 commits into from Oct 8, 2019

Conversation

@jamesagnew
Copy link
Owner

jamesagnew commented Oct 8, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #1530 into master will increase coverage by 0.07%.
The diff coverage is 75.6%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1530      +/-   ##
============================================
+ Coverage     74.67%   74.74%   +0.07%     
- Complexity    12461    12472      +11     
============================================
  Files           904      904              
  Lines         51678    51691      +13     
  Branches       8677     8677              
============================================
+ Hits          38589    38636      +47     
+ Misses         9598     9573      -25     
+ Partials       3491     3482       -9
Impacted Files Coverage Δ Complexity Δ
...r-base/src/main/java/ca/uhn/fhir/util/XmlUtil.java 97.83% <75.6%> (+0.08%) 31 <1> (+1) ⬆️
...ubscription/SubscriptionActivatingInterceptor.java 82.5% <0%> (-2.5%) 22% <0%> (-1%)
.../uhn/fhir/jpa/term/BaseHapiTerminologySvcImpl.java 87.72% <0%> (+0.21%) 377% <0%> (+2%) ⬆️
...chparam/extractor/ResourceIndexedSearchParams.java 90.27% <0%> (+1.08%) 69% <0%> (+1%) ⬆️
...del/entity/ResourceIndexedSearchParamQuantity.java 87.73% <0%> (+1.88%) 33% <0%> (+1%) ⬆️
.../model/entity/ResourceIndexedSearchParamToken.java 90.9% <0%> (+2.02%) 33% <0%> (+1%) ⬆️
...model/entity/ResourceIndexedSearchParamString.java 86.74% <0%> (+2.4%) 29% <0%> (+1%) ⬆️
...-base/src/main/java/ca/uhn/fhir/model/api/Tag.java 56.75% <0%> (+2.7%) 21% <0%> (+1%) ⬆️
.../searchparam/registry/BaseSearchParamRegistry.java 89.94% <0%> (+6.87%) 52% <0%> (ø) ⬇️
...rver/interceptor/ExceptionHandlingInterceptor.java 76.71% <0%> (+8.21%) 19% <0%> (+3%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c4c6f7...c4105d2. Read the comment docs.

jamesagnew added 4 commits Oct 8, 2019
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Oct 8, 2019

This pull request fixes 1 alert when merging c4105d2 into 3c4c6f7 - view on LGTM.com

fixed alerts:

  • 1 for Cross-site scripting
@jamesagnew jamesagnew merged commit 1f1b94a into master Oct 8, 2019
5 checks passed
5 checks passed
LGTM analysis: Java 1 fixed alert
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
codecov/patch 75.6% of diff hit (target 74.67%)
Details
codecov/project 74.74% (+0.07%) compared to 3c4c6f7
Details
jamesagnew.hapi-fhir Build #20191008.8 succeeded
Details
@jamesagnew jamesagnew deleted the ja_20191008_resolve_xxe_in_validator branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.