Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when viewing a Resource in testpage-overlay #1538

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@jiaola
Copy link
Contributor

jiaola commented Oct 11, 2019

Added R5 support for testpage-overly. The current fix doesn't work when a Resource on the left side of the page is clicked. It throws error:

Caused by: java.lang.IllegalStateException: Unknown FHIR version: R5
at ca.uhn.fhir.to.Controller.populateModelForResource (Controller.java:298)

This pull request will fix that.

PS> I also had the same fix for R5 in pom.xml and hapi-fhir-testpage-overlay/src/main/java/ca/uhn/fhir/to/BaseController.java but I noticed that they're already fixed :)

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #1538 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1538      +/-   ##
============================================
- Coverage      74.7%   74.69%   -0.02%     
+ Complexity    12500    12498       -2     
============================================
  Files           905      905              
  Lines         51821    51821              
  Branches       8713     8713              
============================================
- Hits          38713    38706       -7     
- Misses         9601     9605       +4     
- Partials       3507     3510       +3
Impacted Files Coverage Δ Complexity Δ
...n/fhir/jpa/config/HapiFhirHibernateJpaDialect.java 54.16% <0%> (-12.5%) 7% <0%> (-1%)
...r/jpa/search/cache/DatabaseSearchCacheSvcImpl.java 87.35% <0%> (-4.6%) 29% <0%> (ø)
...-base/src/main/java/ca/uhn/fhir/model/api/Tag.java 54.05% <0%> (-2.71%) 20% <0%> (-1%)
.../searchparam/registry/BaseSearchParamRegistry.java 82.53% <0%> (-0.53%) 51% <0%> (-1%)
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 87.2% <0%> (-0.19%) 64% <0%> (-1%)
...base/src/main/java/ca/uhn/fhir/util/StopWatch.java 86.61% <0%> (ø) 41% <0%> (ø) ⬇️
...uhn/fhir/rest/server/method/ReadMethodBinding.java 75.94% <0%> (+2.53%) 27% <0%> (+1%) ⬆️
...ubscription/module/cache/SubscriptionRegistry.java 94.36% <0%> (+2.81%) 19% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c6b88...44b2233. Read the comment docs.

@jamesagnew jamesagnew merged commit 2bf63b1 into jamesagnew:master Oct 31, 2019
4 of 5 checks passed
4 of 5 checks passed
codecov/project 74.69% (-0.02%) compared to 92c6b88
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
codecov/patch Coverage not affected when comparing 92c6b88...44b2233
Details
jamesagnew.hapi-fhir Build #20191011.9 succeeded
Details
jamesagnew added a commit that referenced this pull request Oct 31, 2019
@jamesagnew

This comment has been minimized.

Copy link
Owner

jamesagnew commented Oct 31, 2019

Thanks for the PR! I have merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.