Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client side cache control of metadata retrieval #1541

Merged
merged 2 commits into from Oct 15, 2019

Conversation

@jvitrifork
Copy link
Contributor

jvitrifork commented Oct 15, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1541 into master will decrease coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1541      +/-   ##
============================================
- Coverage     75.14%   75.12%   -0.03%     
+ Complexity    12657    12652       -5     
============================================
  Files           919      919              
  Lines         52003    52006       +3     
  Branches       8703     8704       +1     
============================================
- Hits          39080    39070      -10     
- Misses         9439     9445       +6     
- Partials       3484     3491       +7
Impacted Files Coverage Δ Complexity Δ
...r/rest/server/method/ConformanceMethodBinding.java 80% <75%> (+1.27%) 13 <6> (+1) ⬆️
...ca/uhn/fhir/jpa/model/sched/FireAtIntervalJob.java 86.66% <0%> (-13.34%) 5% <0%> (ø)
...rver/interceptor/ExceptionHandlingInterceptor.java 68.49% <0%> (-8.22%) 16% <0%> (-3%)
.../subscription/module/cache/SubscriptionLoader.java 83.63% <0%> (-3.64%) 11% <0%> (-1%)
...model/entity/ResourceIndexedSearchParamString.java 84.33% <0%> (-2.41%) 28% <0%> (-1%)
.../model/entity/ResourceIndexedSearchParamToken.java 88.88% <0%> (-2.03%) 32% <0%> (-1%)
...del/entity/ResourceIndexedSearchParamQuantity.java 85.84% <0%> (-1.89%) 32% <0%> (-1%)
...rc/main/java/ca/uhn/fhir/context/ModelScanner.java 77.03% <0%> (-0.71%) 74% <0%> (-1%)
.../uhn/fhir/jpa/search/SearchCoordinatorSvcImpl.java 89.87% <0%> (+0.18%) 68% <0%> (ø) ⬇️
...uhn/fhir/rest/server/method/ReadMethodBinding.java 75.94% <0%> (+2.53%) 27% <0%> (+1%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2725797...755d193. Read the comment docs.

@jamesagnew jamesagnew merged commit 82a6221 into jamesagnew:master Oct 15, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 75% of diff hit (target 75.14%)
Details
codecov/project 75.12% (-0.03%) compared to 2725797
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Java No new or fixed alerts
Details
jamesagnew.hapi-fhir Build #20191015.1 succeeded
Details
jamesagnew added a commit that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.