Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix length for normalized value #1547
There was an issue where a normalized string value couldn't be stored into the database because the normalized string value was too long (over 200 characters). It seems that the normalization which is done with the form
The exception was:
This could be fixed by taking a substring of the normalized value as well before the value is passed on to the
Let me know what do you think.
@@ Coverage Diff @@ ## master #1547 +/- ## ========================================= Coverage ? 75.19% Complexity ? 12679 ========================================= Files ? 923 Lines ? 52006 Branches ? 8707 ========================================= Hits ? 39107 Misses ? 9421 Partials ? 3478
jamesagnew left a comment
Good call, that didn't occur to me that normalizing could make the string longer.. but that does make sense.
One change requested but overall I think this is a good approach!