New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the checkstyle location to play nice on Win #223

Merged
merged 1 commit into from Sep 15, 2015

Conversation

Projects
None yet
2 participants
@SingingTree
Contributor

SingingTree commented Sep 12, 2015

Removed the file:// prefix on the checkstyle config location. This appeared to be breaking the site build on Windows. I've also tested this on Linux (OpenSuse 13.2) and believe that change has not broken anything. However it would be good if someone else could make sure the site still builds with this change on Linux.

If there are reasons not to remove the file:// prefix, or issues with doing so, please let me know, and I'll attempt to remedy the build issues on Windows via other means.

Adjust the checkstyle location to play nice on Win
Removed the file:// prefix on the checkstyle config location, this is
needed for the site build to work on Windows. I've tested this on Linux,
though not as thouroughly.
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Sep 15, 2015

Thanks for the submission!

jamesagnew added a commit that referenced this pull request Sep 15, 2015

Merge pull request #223 from SingingTree/checkstyle_config_location
Adjust the checkstyle location to play nice on Win

@jamesagnew jamesagnew merged commit 76ee015 into jamesagnew:master Sep 15, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 82.991%
Details

jamesagnew added a commit that referenced this pull request Sep 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment