Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing parameters for HTTP client request pool max connections in RestfulClientFactory #288

Merged
merged 1 commit into from Jan 22, 2016

Conversation

Projects
None yet
2 participants
@matt-blanchette
Copy link
Contributor

matt-blanchette commented Jan 20, 2016

The current RestfulClientFactory uses the default HTTP client PoolingHttpClientConnectionManager settings for max number of connections.
The defaults for these are 20 max total connections and 2 max per route.

These changes expose parameters on RestfulClientFactory to allow overriding these defaults.

The default for max connections per route is also changed here from 2 to 20 (using the same value as max total connections).

Other possible approaches:

  • Expose HttpClientBuilder in RestfulClientFactory, allow subclasses to override settings
    • Expose a setter for IRestfulClientFactory in FhirContext to allow subclassing
Exposing http client request pool max parameters on restful client fa…
…ctory:

* added setters on restful client factory to allow changing max total connections and max connections per route for pooling http connection manager
* added defaults for max total connections and max connections per route on restful client factory interface
@jamesagnew

This comment has been minimized.

Copy link
Owner

jamesagnew commented Jan 22, 2016

Thanks! This looks awesome, merging it now.

jamesagnew added a commit that referenced this pull request Jan 22, 2016

jamesagnew added a commit that referenced this pull request Jan 22, 2016

Merge pull request #288 from matt-blanchette/master
Exposing parameters for HTTP client request pool max connections in RestfulClientFactory

@jamesagnew jamesagnew merged commit e73f409 into jamesagnew:master Jan 22, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.04%) to 84.572%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.