New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated jaxrsserver base and example for DSTU3 #355

Merged
merged 2 commits into from May 5, 2016

Conversation

Projects
None yet
2 participants
@euvitudo
Contributor

euvitudo commented Apr 29, 2016

Added support for specifying DSTU3 in the constructors, where the default is DSTU2, to maintain backwards compatibility.
Updated interface usage to IBase... (e.g., IResource -> IBaseResource), which is compatible with DSTU3.
Added tests specifically for DSTU3; kept the existing tests as DSTU2.
Provided examples for DSTU3.

Updated jaxrsserver base and example for DSTU3
Added support for specifying DSTU3 in the constructors, where the default is DSTU2, to maintain backwards compatibility.
Updated interface usage to IBase... (e.g., IResource -> IBaseResource), which is compatible with DSTU3.
Added tests specifically for DSTU3; kept the existing tests as DSTU2.
Provided examples for DSTU3.
@euvitudo

This comment has been minimized.

Contributor

euvitudo commented Apr 29, 2016

Regarding the build failure--it passes on my system, with the following:

$ java -version
java version "1.8.0_91"
Java(TM) SE Runtime Environment (build 1.8.0_91-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.91-b14, mixed mode)

and

Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T09:41:47-07:00)
Maven home: /usr/local/Cellar/maven/3.3.9/libexec
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.11.4", arch: "x86_64", family: "mac"

The test failure is due to the following:

//      assertEquals("2015-06-22T15:48:57.554-04:00", response.getMeta().getLastUpdated().toString());
        assertEquals("Mon Jun 22 13:48:57 MDT 2015", response.getMeta().getLastUpdated().toString());

where the latter works on my system, but apparently not on the TravisCI system. Also, strange that it passes when it's not ISO format. :( Any thoughts?

@euvitudo

This comment has been minimized.

Contributor

euvitudo commented Apr 29, 2016

Nevermind. I was using toString() instead of getValueAsString().

Use getValueAsString() instead of toString().
Simple oversight, where toString() on the java.util.Date lastUpdated was wrong.
Needed to getLastUpdatedElement().getValueAsString().
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 5, 2016

This is really nicely done! Merging it now.

@jamesagnew jamesagnew merged commit ad9ff20 into jamesagnew:master May 5, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

jamesagnew added a commit that referenced this pull request May 5, 2016

@euvitudo

This comment has been minimized.

Contributor

euvitudo commented May 5, 2016

Thank you James!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment