New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add null check in JsonParser, Relax property handling introduced in Jaxp 1.5 #359

Merged
merged 1 commit into from May 5, 2016

Conversation

Projects
None yet
3 participants
@subhrajyotim
Contributor

subhrajyotim commented May 4, 2016

Hello James,
While developing with HAPI, based on the data I am using, I have made 2 modifications:

  • to handle Null check in case of arrays in JsonParser
  • To relax the property settings which are only supported by Jaxp1.5 only, some of the jvms being used still now have Jaxp1.4, to maintain backward compatibility, in SchemaBaseValidator

Please review, and see if this could help in anyways.

Thanks,
Subhro.

Fix: Add null check in JsonParser, Relax property handling introduced…
… in Jaxp 1.5 for some compatibility with existing 1.4 version
@coveralls

This comment has been minimized.

coveralls commented May 4, 2016

Coverage Status

Coverage decreased (-0.02%) to 84.541% when pulling 284f0f1 on subhrajyotim:master into b4d3a7b on jamesagnew:master.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 5, 2016

Thanks for the contribution! Looks good, merging it now.

jamesagnew added a commit that referenced this pull request May 5, 2016

@jamesagnew jamesagnew merged commit 03e90b9 into jamesagnew:master May 5, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.02%) to 84.541%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment