New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong comment, unable to set type in new versions #361

Merged
merged 1 commit into from May 6, 2016

Conversation

Projects
None yet
3 participants
@Virdulys
Contributor

Virdulys commented May 5, 2016

No description provided.

@coveralls

This comment has been minimized.

coveralls commented May 5, 2016

Coverage Status

Coverage decreased (-0.006%) to 84.47% when pulling 2cf79d2 on Virdulys:patch-2 into fb277a0 on jamesagnew:master.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 6, 2016

Hi @Virdulys, thanks for the patch, I'll merge it now.

I should point out though that if you're doing new development you should consider migrating to the DSTU2/STU3 Bundle resources instead of the DSTU1 Bundle that this patch fixes. This class will be removed at some point now that DSTU1 is starting to go away.

@jamesagnew jamesagnew merged commit b066bda into jamesagnew:master May 6, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.006%) to 84.47%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jamesagnew added a commit that referenced this pull request May 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment