New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON-like resource structures #469

Merged
merged 2 commits into from Oct 19, 2016

Conversation

Projects
None yet
3 participants
@bdenton
Collaborator

bdenton commented Oct 15, 2016

(resubmitting after recovering my branch from a couple of bad merges)

This enhancement addresses the need to be able to serialize FHIR resources to and from streams other that Json-P or Gson. Here are two examples:

  1. When building an equivalent of the jpaserver implemented in native MongoDB (no JPA or JDO), it was necessary to be able to serialize/deserialize FHIR resources via BSONReader and BSONWriter. This is possible (with some pain) with Json-P but is not at all possible with Gson.

  2. We have built a general purpose data mapping engine that is able to map from a set of customer/application-specific sets of data into FHIR resources. The output of this mapping engine is a JSON-like data structure implemented in Java Maps, Lists, and scalars.

This pull request extends the IParser interface and updates the JSONParser to implement the sub-interface so that any sort of Json-like data structure or framework can be integrated in the future.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 15, 2016

Coverage Status

Coverage decreased (-0.4%) to 87.435% when pulling 205bafd on bdenton:support-json-like-structures into 4c28414 on jamesagnew:master.

coveralls commented Oct 15, 2016

Coverage Status

Coverage decreased (-0.4%) to 87.435% when pulling 205bafd on bdenton:support-json-like-structures into 4c28414 on jamesagnew:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 15, 2016

Coverage Status

Coverage decreased (-0.4%) to 87.459% when pulling 01a955b on bdenton:support-json-like-structures into 4c28414 on jamesagnew:master.

coveralls commented Oct 15, 2016

Coverage Status

Coverage decreased (-0.4%) to 87.459% when pulling 01a955b on bdenton:support-json-like-structures into 4c28414 on jamesagnew:master.

@bdenton

This comment has been minimized.

Show comment
Hide comment
@bdenton

bdenton Oct 19, 2016

Collaborator

James..
are you OK with this commit even though I can't seem to get Coveralls to give me a good score?
cheers, Bill

Collaborator

bdenton commented Oct 19, 2016

James..
are you OK with this commit even though I can't seem to get Coveralls to give me a good score?
cheers, Bill

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 19, 2016

Owner

Bill, this is fantastic. I know it was painful to get it resubmitted with git being the nuisance it can be... but this looks awesome now. I'm gonna merge it now.

Owner

jamesagnew commented Oct 19, 2016

Bill, this is fantastic. I know it was painful to get it resubmitted with git being the nuisance it can be... but this looks awesome now. I'm gonna merge it now.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 19, 2016

Owner

Oh, and yeah.. Coveralls can be weird sometime. It doesn't appear that coverage changed in any meaningful way so I'm not to worried about that.

Owner

jamesagnew commented Oct 19, 2016

Oh, and yeah.. Coveralls can be weird sometime. It doesn't appear that coverage changed in any meaningful way so I'm not to worried about that.

jamesagnew added a commit that referenced this pull request Oct 19, 2016

@jamesagnew jamesagnew merged commit 913fd32 into jamesagnew:master Oct 19, 2016

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.4%) to 87.459%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment