Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#516 Report invalid values for enums through parser error handler #525

Merged

Conversation

@lawley
Copy link
Contributor

@lawley lawley commented Dec 6, 2016

This patch catches the low-level IllegalArgumentException from the model code and instead reports an invalidValue through the parser's error handler.
Unit test included

@coveralls
Copy link

@coveralls coveralls commented Dec 6, 2016

Coverage Status

Coverage increased (+0.001%) to 87.681% when pulling a9a3507 on aehrc:feature/parser_exception_handling into e8fad33 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Dec 10, 2016
@jamesagnew jamesagnew merged commit 0def3d5 into jamesagnew:master Dec 10, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.001%) to 87.681%
Details
@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Dec 10, 2016

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.