Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ParameterUtil.splitParameterString correctly parses consecutive unescaped delimiter #538

Merged

Conversation

@CarthageKing
Copy link

@CarthageKing CarthageKing commented Jan 12, 2017

This PR fixes #514 and makes modifications to ParameterUtil.splitParameterString such that a QuantityParam value of '5.5||mg' the 'mg' is treated as the 'unit' and not as the 'system'.

here are at least two unescaped and consecutive variants of the given
char in the string.

This ensures that for example a QuantityParam with a param value of
"5.5||mg" the "mg" will not be treated as the 'system' but be treated
correctly as the 'unit' of the parameter object.
@coveralls
Copy link

@coveralls coveralls commented Jan 12, 2017

Coverage Status

Coverage increased (+0.007%) to 81.488% when pulling a6a1416 on CarthageKing:feature-parameterutil-fix into af32c4b on jamesagnew:master.

@jamesagnew jamesagnew merged commit 788792e into jamesagnew:master Jan 29, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 81.488%
Details
jamesagnew added a commit that referenced this pull request Jan 29, 2017
@CarthageKing CarthageKing deleted the CarthageKing:feature-parameterutil-fix branch Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.