Ensure ParameterUtil.splitParameterString correctly parses consecutive unescaped delimiter #538

Merged
merged 1 commit into from Jan 29, 2017

Conversation

Projects
None yet
3 participants
@CarthageKing

This PR fixes #514 and makes modifications to ParameterUtil.splitParameterString such that a QuantityParam value of '5.5||mg' the 'mg' is treated as the 'unit' and not as the 'system'.

michael.i.calderero
Place empty values when splitting a parameter with a certain char and
here are at least two unescaped and consecutive variants of the given
char in the string.

This ensures that for example a QuantityParam with a param value of
"5.5||mg" the "mg" will not be treated as the 'system' but be treated
correctly as the 'unit' of the parameter object.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 12, 2017

Coverage Status

Coverage increased (+0.007%) to 81.488% when pulling a6a1416 on CarthageKing:feature-parameterutil-fix into af32c4b on jamesagnew:master.

Coverage Status

Coverage increased (+0.007%) to 81.488% when pulling a6a1416 on CarthageKing:feature-parameterutil-fix into af32c4b on jamesagnew:master.

@jamesagnew jamesagnew merged commit 788792e into jamesagnew:master Jan 29, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.007%) to 81.488%
Details

jamesagnew added a commit that referenced this pull request Jan 29, 2017

@CarthageKing CarthageKing deleted the CarthageKing:feature-parameterutil-fix branch Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment