Jaxrs sever evolution #543

Merged
merged 7 commits into from Mar 17, 2017

Conversation

Projects
None yet
3 participants
@SRiviere
Contributor

SRiviere commented Jan 19, 2017

Like discussed in Amsterdam FHIR dev, i added the possibility to use the configuration of the baseServerUrl to generate the extension url, via a key word: %BASE_SERVER_URL%, which is replace during the parsing of the resource if present.

I also modify the validation to use the datatype profile when available in the structure definition instead of always the default one. Like that if a datatype is redefined it can be validate.

And i made little modifications in the Jax-rs module: enable the @Validate for the server, and switch to CapabilityStatement for DSTU3

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 19, 2017

Coverage Status

Coverage increased (+0.03%) to 81.55% when pulling 6cc7eeb on SRiviere:jaxrs-sever-evolution into 06f9d86 on jamesagnew:master.

Coverage Status

Coverage increased (+0.03%) to 81.55% when pulling 6cc7eeb on SRiviere:jaxrs-sever-evolution into 06f9d86 on jamesagnew:master.

Merge branch 'master' of https://github.com/jamesagnew/hapi-fhir into…
… jaxrs-sever-evolution

# Conflicts:
#	hapi-fhir-structures-dstu3/src/test/java/ca/uhn/fhir/parser/JsonParserDstu3Test.java
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 27, 2017

Coverage Status

Coverage decreased (-0.002%) to 81.537% when pulling dabb3ea on SRiviere:jaxrs-sever-evolution into 97f1e55 on jamesagnew:master.

Coverage Status

Coverage decreased (-0.002%) to 81.537% when pulling dabb3ea on SRiviere:jaxrs-sever-evolution into 97f1e55 on jamesagnew:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 6, 2017

Coverage Status

Changes Unknown when pulling 3bf6555 on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

Coverage Status

Changes Unknown when pulling 3bf6555 on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

+ private static final long serialVersionUID = 1L;
+
+ @Child(name = "homeless", order = 1)
+ @Extension(url = "%BASE_SERVER_URL%/StructureDefinition/homeless", definedLocally = true, isModifier = false)

This comment has been minimized.

@jamesagnew

jamesagnew Feb 6, 2017

Owner

This is really neat! Sorry for taking a while to review it, life's been crazy lately..

Really the only question I have is whether we actually need the substitution variable in this.

Would it make sense to just let you put either an absolute or a relative URL in the extension url? In other words, set it up so you could either do:

    @Extension(url = "http://example.com/StructureDefinition/homeless", definedLocally = true, isModifier = false)

or you could do:

    @Extension(url = "StructureDefinition/homeless", definedLocally = true, isModifier = false)

..and the parser could just assume you want the substitution if there is no base. Would that make sense?

@jamesagnew

jamesagnew Feb 6, 2017

Owner

This is really neat! Sorry for taking a while to review it, life's been crazy lately..

Really the only question I have is whether we actually need the substitution variable in this.

Would it make sense to just let you put either an absolute or a relative URL in the extension url? In other words, set it up so you could either do:

    @Extension(url = "http://example.com/StructureDefinition/homeless", definedLocally = true, isModifier = false)

or you could do:

    @Extension(url = "StructureDefinition/homeless", definedLocally = true, isModifier = false)

..and the parser could just assume you want the substitution if there is no base. Would that make sense?

This comment has been minimized.

@SRiviere

SRiviere Feb 7, 2017

Contributor

Indeed like is done for the resource profile, i should have think that before :). I'll make the modifications.

@SRiviere

SRiviere Feb 7, 2017

Contributor

Indeed like is done for the resource profile, i should have think that before :). I'll make the modifications.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 8, 2017

Coverage Status

Changes Unknown when pulling c3447c3 on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

Coverage Status

Changes Unknown when pulling c3447c3 on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 17, 2017

Coverage Status

Coverage increased (+0.02%) to 78.11% when pulling 45e4bd9 on SRiviere:jaxrs-sever-evolution into 5282110 on jamesagnew:master.

Coverage Status

Coverage increased (+0.02%) to 78.11% when pulling 45e4bd9 on SRiviere:jaxrs-sever-evolution into 5282110 on jamesagnew:master.

@jamesagnew jamesagnew merged commit 3c6dc5d into jamesagnew:master Mar 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 78.11%
Details

jamesagnew added a commit that referenced this pull request Mar 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment