Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct paths to profiles and valuesets/codesystems #568

Merged
merged 3 commits into from Mar 17, 2017

Conversation

@lawley
Copy link
Contributor

@lawley lawley commented Feb 23, 2017

This is a patch for #567

@coveralls
Copy link

@coveralls coveralls commented Feb 23, 2017

Coverage Status

Coverage remained the same at 81.75% when pulling 5ef8945 on aehrc:feature/dstu2_1_profile_paths into 0d06627 on jamesagnew:master.

lawley added 2 commits Feb 23, 2017
HapiWorkerContext needed ValueSet expansion support for validation, now that resources are found and loaded.
ParserBase had a bug when comparing names (was not looking at IdPart)
Profiles had errors in FHIRPaths using invalid $context name
@coveralls
Copy link

@coveralls coveralls commented Mar 13, 2017

Coverage Status

Coverage increased (+0.02%) to 81.77% when pulling 884bfbe on aehrc:feature/dstu2_1_profile_paths into 0d06627 on jamesagnew:master.

@lawley
Copy link
Contributor Author

@lawley lawley commented Mar 13, 2017

Note, by fixing the paths to profiles and valuesets/codesystems for dstu2.1, this enabled additional parts of the validation code to run and then uncovered bugs due to lack of (implemented) valueset expand support and problems with FHIRPath strings in some resource profiles.

I've fixed these as best I can, but am not a FHIRPath expert so my fixes may not be accurate.

@jamesagnew jamesagnew merged commit 54376a5 into jamesagnew:master Mar 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 81.77%
Details
jamesagnew added a commit that referenced this pull request Mar 17, 2017
@lawley lawley deleted the aehrc:feature/dstu2_1_profile_paths branch Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.