Add validation results to oo #595

Merged
merged 7 commits into from Mar 16, 2017

Conversation

Projects
None yet
3 participants
@jamesagnew
Owner

jamesagnew commented Mar 15, 2017

@dmuylwyk I actually thought of an even better way to implement this.

Review pls.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 15, 2017

Coverage Status

Coverage decreased (-0.006%) to 81.776% when pulling 901e256 on add_validation_results_to_oo into a867890 on master.

Coverage Status

Coverage decreased (-0.006%) to 81.776% when pulling 901e256 on add_validation_results_to_oo into a867890 on master.

dmuylwyk added some commits Mar 15, 2017

Update changes.xml
Corrected reference to issue 586 (was 585). Corrected order of actions for issues 586 and 595 (was reversed).
Update changes.xml
Should have been 585 after all. Whoops!
Update changes.xml
Adding an item for pull request 565 that was previously approved and merged.
@dmuylwyk

Approved assuming you address the comment regarding the failing test.

+
+ String encodedOo = myFhirCtx.newJsonParser().setPrettyPrint(true).encodeResourceToString(outcome);
+ ourLog.info(encodedOo);
+ assertThat(encodedOo, containsString("The content of element 'Observation' is not complete"));

This comment has been minimized.

@dmuylwyk

dmuylwyk Mar 15, 2017

Collaborator

These tests appear to be failing in Travis CI due to locale.

See:

  • ResourceProviderDstu3Test.testCreateIncludesRequestValidatorInterceptorOutcome:421

Compare:

  • "The content of element 'Observation' is not complete"
  • "元素 'Observation' 的內容不完整。預期一個"
@dmuylwyk

dmuylwyk Mar 15, 2017

Collaborator

These tests appear to be failing in Travis CI due to locale.

See:

  • ResourceProviderDstu3Test.testCreateIncludesRequestValidatorInterceptorOutcome:421

Compare:

  • "The content of element 'Observation' is not complete"
  • "元素 'Observation' 的內容不完整。預期一個"

This comment has been minimized.

@dmuylwyk

dmuylwyk Mar 16, 2017

Collaborator

I'll modify the test assertion to check for "cvc-complex-type.2.4.b" instead.

@dmuylwyk

dmuylwyk Mar 16, 2017

Collaborator

I'll modify the test assertion to check for "cvc-complex-type.2.4.b" instead.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 16, 2017

Coverage Status

Coverage increased (+0.009%) to 81.79% when pulling 6749e31 on add_validation_results_to_oo into a867890 on master.

Coverage Status

Coverage increased (+0.009%) to 81.79% when pulling 6749e31 on add_validation_results_to_oo into a867890 on master.

@dmuylwyk dmuylwyk merged commit 0be818c into master Mar 16, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 81.79%
Details

@dmuylwyk dmuylwyk deleted the add_validation_results_to_oo branch Mar 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment