Fix FhirContext initialisation race condition. #610

Merged
merged 1 commit into from Apr 17, 2017

Conversation

Projects
None yet
3 participants
@dangerousben
Contributor

dangerousben commented Mar 28, 2017

No description provided.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Apr 17, 2017

Owner

This looks great! I'm going to merge it now.

Owner

jamesagnew commented Apr 17, 2017

This looks great! I'm going to merge it now.

@jamesagnew jamesagnew merged commit 9201692 into jamesagnew:master Apr 17, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

jamesagnew added a commit that referenced this pull request Apr 17, 2017

jamesagnew added a commit that referenced this pull request Apr 17, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Apr 17, 2017

Owner

FYI I've added a double-check in FhirContext#validateInitialized just to keep performance up. That method gets called multiple times during a parse cycle so it needs to be pretty fast. Let me know if you have any concerns with the implementation! The test does still pass so that seems like a good sign.

Owner

jamesagnew commented Apr 17, 2017

FYI I've added a double-check in FhirContext#validateInitialized just to keep performance up. That method gets called multiple times during a parse cycle so it needs to be pretty fast. Let me know if you have any concerns with the implementation! The test does still pass so that seems like a good sign.

@dangerousben dangerousben deleted the dangerousben:init-race-condition branch Apr 18, 2017

jamesagnew added a commit that referenced this pull request Apr 18, 2017

Bring DSTU3 structs up to FHIR R3
Squashed commit of the following:

commit 65b70d3
Author: James <jamesagnew@gmail.com>
Date:   Tue Apr 18 07:44:08 2017 -0400

    More work on bringing structs up to date

commit 1df2de0
Author: James <jamesagnew@gmail.com>
Date:   Tue Apr 18 07:12:45 2017 -0400

    Working

commit 9a51323
Author: James <jamesagnew@gmail.com>
Date:   Mon Apr 17 22:18:24 2017 -0400

    Updates to STU3

commit 40aebba
Author: James <jamesagnew@gmail.com>
Date:   Mon Apr 17 18:30:26 2017 -0400

    Fix regression caused by #610

jamesagnew added a commit that referenced this pull request Apr 19, 2017

@Jaypeg85 Jaypeg85 referenced this pull request Apr 21, 2017

Merged

concurrency_issue #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment