Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FhirContext initialisation race condition. #610

Merged
merged 1 commit into from Apr 17, 2017

Conversation

@dangerousben
Copy link
Contributor

@dangerousben dangerousben commented Mar 28, 2017

No description provided.

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Apr 17, 2017

This looks great! I'm going to merge it now.

@jamesagnew jamesagnew merged commit 9201692 into jamesagnew:master Apr 17, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jamesagnew added a commit that referenced this pull request Apr 17, 2017
jamesagnew added a commit that referenced this pull request Apr 17, 2017
@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Apr 17, 2017

FYI I've added a double-check in FhirContext#validateInitialized just to keep performance up. That method gets called multiple times during a parse cycle so it needs to be pretty fast. Let me know if you have any concerns with the implementation! The test does still pass so that seems like a good sign.

@dangerousben dangerousben deleted the dangerousben:init-race-condition branch Apr 18, 2017
jamesagnew added a commit that referenced this pull request Apr 18, 2017
Squashed commit of the following:

commit 65b70d3
Author: James <jamesagnew@gmail.com>
Date:   Tue Apr 18 07:44:08 2017 -0400

    More work on bringing structs up to date

commit 1df2de0
Author: James <jamesagnew@gmail.com>
Date:   Tue Apr 18 07:12:45 2017 -0400

    Working

commit 9a51323
Author: James <jamesagnew@gmail.com>
Date:   Mon Apr 17 22:18:24 2017 -0400

    Updates to STU3

commit 40aebba
Author: James <jamesagnew@gmail.com>
Date:   Mon Apr 17 18:30:26 2017 -0400

    Fix regression caused by #610
jamesagnew added a commit that referenced this pull request Apr 19, 2017
@Jaypeg85 Jaypeg85 mentioned this pull request Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.