Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature make bundle fullurl override configurable #624

Conversation

@CarthageKing
Copy link

@CarthageKing CarthageKing commented Apr 13, 2017

This PR makes the overriding of resource ids when a Bundle.entry.fullUrl is specified a configurable behavior.

When this behavior is disabled via the added option in the FhirContext or the IParser, then Bundle.entry.fullUrl will not replace whatever resource id is set for resource entry in the bundle. This is useful for implementations such as ours that want to do some further checks/resolutions against the resource id and fullUrl and do some proper error reporting.

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Apr 17, 2017

Thanks for the PR! Merging now.

@jamesagnew jamesagnew merged commit 282e028 into jamesagnew:master Apr 17, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
jamesagnew added a commit that referenced this pull request Apr 17, 2017
@CarthageKing CarthageKing deleted the CarthageKing:feature-make-bundle-fullurl-override-configurable branch May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.