Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the charset from the content-type header of the HttpRequest instead of always using the default charset. #633

Merged

Conversation

@gijsbert802
Copy link
Contributor

@gijsbert802 gijsbert802 commented Apr 25, 2017

Second attempt. The Content-type header from the HttpRequest is now used instead of the Content-type of HttpEntity (which apparently is always null).
All tests pass now.

…ad of always using the default charset.
@coveralls
Copy link

@coveralls coveralls commented Apr 25, 2017

Coverage Status

Coverage decreased (-0.002%) to 77.285% when pulling 9ffbeb8 on gijsbert802:use-charset-from-http-header-2 into f21ab8b on jamesagnew:master.

jamesagnew added a commit that referenced this pull request May 20, 2017
@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented May 20, 2017

Looks great! Merging now, thanks. :)

@jamesagnew jamesagnew merged commit 9ca8a28 into jamesagnew:master May 20, 2017
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.002%) to 77.285%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.