Use the charset from the content-type header of the HttpRequest instead of always using the default charset. #633

Merged
merged 1 commit into from May 20, 2017

Conversation

Projects
None yet
3 participants
@gijsbert802
Contributor

gijsbert802 commented Apr 25, 2017

Second attempt. The Content-type header from the HttpRequest is now used instead of the Content-type of HttpEntity (which apparently is always null).
All tests pass now.

Use the charset from the content-type header of the HttpRequest inste…
…ad of always using the default charset.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Apr 25, 2017

Coverage Status

Coverage decreased (-0.002%) to 77.285% when pulling 9ffbeb8 on gijsbert802:use-charset-from-http-header-2 into f21ab8b on jamesagnew:master.

Coverage Status

Coverage decreased (-0.002%) to 77.285% when pulling 9ffbeb8 on gijsbert802:use-charset-from-http-header-2 into f21ab8b on jamesagnew:master.

jamesagnew added a commit that referenced this pull request May 20, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew May 20, 2017

Owner

Looks great! Merging now, thanks. :)

Owner

jamesagnew commented May 20, 2017

Looks great! Merging now, thanks. :)

@jamesagnew jamesagnew merged commit 9ca8a28 into jamesagnew:master May 20, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.002%) to 77.285%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment