Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null access fix for BaseClient exception handlers. #649

Merged
merged 1 commit into from Jun 8, 2017

Conversation

@maclema
Copy link
Contributor

@maclema maclema commented May 16, 2017

Fix for null access on httpRequest in DataFormatException and IOException handlers - passing UNKNOWN as the verb and URI when the httpRequest is null, this is better than a null access being thrown when calling .execute()

Fix for null access on httpRequest in DataFormatException and IOException handlers.
@coveralls
Copy link

@coveralls coveralls commented May 16, 2017

Coverage Status

Coverage decreased (-0.006%) to 77.362% when pulling 06919f9 on iceoss:rest-client-patch into b2996d3 on jamesagnew:master.

@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Jun 8, 2017

Thanks for the contribution!! Merging it now.

@jamesagnew jamesagnew merged commit 7d5fbe7 into jamesagnew:master Jun 8, 2017
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.006%) to 77.362%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jamesagnew added a commit that referenced this pull request Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.