Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SearchBuilder query generation for code:modifier searches #656

Merged
merged 1 commit into from Jun 8, 2017

Conversation

@lawley
Copy link
Contributor

@lawley lawley commented May 29, 2017

Uses disjunction of AND and IN for code:modifier searches.

Without this, OR conditions with too many disjuncts are generated which can lead to
failures in the underlying database code generation.

Without this, OR conditions with too many disjuncts are generated which can lead to
failures in the underlying database code generation.
@coveralls
Copy link

@coveralls coveralls commented May 29, 2017

Coverage Status

Coverage increased (+0.003%) to 76.733% when pulling d0a927a on aehrc:feature/scalable_searchbuilder into 6168f4a on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Jun 8, 2017
@jamesagnew
Copy link
Owner

@jamesagnew jamesagnew commented Jun 8, 2017

This is super cool. Merging now, thanks!

@jamesagnew jamesagnew merged commit 4caa5df into jamesagnew:master Jun 8, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 76.733%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.