Improve SearchBuilder query generation for code:modifier searches #656

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
3 participants
@lawley
Contributor

lawley commented May 29, 2017

Uses disjunction of AND and IN for code:modifier searches.

Without this, OR conditions with too many disjuncts are generated which can lead to
failures in the underlying database code generation.

use disj. of AND and IN for code:modifier searches
Without this, OR conditions with too many disjuncts are generated which can lead to
failures in the underlying database code generation.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 29, 2017

Coverage Status

Coverage increased (+0.003%) to 76.733% when pulling d0a927a on aehrc:feature/scalable_searchbuilder into 6168f4a on jamesagnew:master.

Coverage Status

Coverage increased (+0.003%) to 76.733% when pulling d0a927a on aehrc:feature/scalable_searchbuilder into 6168f4a on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Jun 8, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Jun 8, 2017

Owner

This is super cool. Merging now, thanks!

Owner

jamesagnew commented Jun 8, 2017

This is super cool. Merging now, thanks!

@jamesagnew jamesagnew merged commit 4caa5df into jamesagnew:master Jun 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 76.733%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment