New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaxrs server evolution #714

Merged
merged 4 commits into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@SRiviere
Contributor

SRiviere commented Aug 22, 2017

Add the possibility to set Jax-Rs component to the default client.
Add some comments about how to use it in multi threading context, as default Jax-Rs client implementation is not thread safe in static context.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Aug 22, 2017

Owner

Hmm, any idea what this failure is about?

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/jamesagnew/hapi-fhir/hapi-fhir-jaxrsserver-base/src/main/java/ca/uhn/fhir/jaxrs/client/JaxRsRestfulClientFactory.java:[125,17] error: method resetHttpClient() is already defined in class JaxRsRestfulClientFactory

Owner

jamesagnew commented Aug 22, 2017

Hmm, any idea what this failure is about?

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/jamesagnew/hapi-fhir/hapi-fhir-jaxrsserver-base/src/main/java/ca/uhn/fhir/jaxrs/client/JaxRsRestfulClientFactory.java:[125,17] error: method resetHttpClient() is already defined in class JaxRsRestfulClientFactory

@SRiviere

This comment has been minimized.

Show comment
Hide comment
@SRiviere

SRiviere Aug 22, 2017

Contributor

Sorry i made a mistake during the merge, and a method was duplicated

Contributor

SRiviere commented Aug 22, 2017

Sorry i made a mistake during the merge, and a method was duplicated

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 22, 2017

Coverage Status

Changes Unknown when pulling b12a16d on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

coveralls commented Aug 22, 2017

Coverage Status

Changes Unknown when pulling b12a16d on SRiviere:jaxrs-sever-evolution into ** on jamesagnew:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 5, 2017

Coverage Status

Coverage increased (+1.5%) to 81.676% when pulling 6a70453 on SRiviere:jaxrs-sever-evolution into ff8b560 on jamesagnew:master.

coveralls commented Oct 5, 2017

Coverage Status

Coverage increased (+1.5%) to 81.676% when pulling 6a70453 on SRiviere:jaxrs-sever-evolution into ff8b560 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Oct 26, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 26, 2017

Owner

Thanks again, merging now!

Owner

jamesagnew commented Oct 26, 2017

Thanks again, merging now!

@jamesagnew jamesagnew merged commit b35cab2 into jamesagnew:master Oct 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 81.676%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment