New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs with inverted test for If-Modified-Since (impl and tests) #717

Merged
merged 1 commit into from Oct 26, 2017

Conversation

Projects
None yet
3 participants
@lawley
Contributor

lawley commented Aug 24, 2017

The implementation of support for If-Modified-Since and the corresponding unit tests are broken.

The implementation has the timestamp comparison test backwards and the unit tests have the wrong expectations.

Implementation updated to use correct test, and unit tests have been updated to 1. fix the expectations, and 2. also cover the case where the header timestamp is identical to the modified timestamp.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 24, 2017

Coverage Status

Coverage decreased (-0.006%) to 80.177% when pulling a4365f9 on aehrc:feature/ifModifiedSince_bugfix_master into 72245c0 on jamesagnew:master.

coveralls commented Aug 24, 2017

Coverage Status

Coverage decreased (-0.006%) to 80.177% when pulling a4365f9 on aehrc:feature/ifModifiedSince_bugfix_master into 72245c0 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Oct 26, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 26, 2017

Owner

Man, that's quite the issue. Thanks for the contribution, merging now!

Owner

jamesagnew commented Oct 26, 2017

Man, that's quite the issue. Thanks for the contribution, merging now!

@jamesagnew jamesagnew merged commit 0fec048 into jamesagnew:master Oct 26, 2017

1 of 2 checks passed

coverage/coveralls Coverage decreased (-0.006%) to 80.177%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment