New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #724 - Resource IDs are now copied when copying instances of subclasses of DomainResource for DSTU2 and DSTU2.1. #725

Merged
merged 5 commits into from Oct 31, 2017

Conversation

Projects
None yet
2 participants
@InfiniteLoop90
Contributor

InfiniteLoop90 commented Sep 3, 2017

Resource IDs are now copied when copying instances of subclasses of DomainResource for DSTU2 and DSTU2.1. (STU3 and R4 already had this fix)

InfiniteLoop90 added some commits Sep 3, 2017

Fixes #724 - Resource IDs are now copied when copying instances of su…
…bclasses of DomainResource for DSTU2 and DSTU2.1. (STU3 and R4 already had this fix)
Also fixes #724 - Added unit tests to ensure that the IDs of instance…
…s of DomainResource subclasses get copied as expected
@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Sep 5, 2017

Contributor

When looking at this pull request, you'll want to ignore whitespace. My IDE apparently changed the line endings and I didn't realize that until now. Sorry!

Nevermind! I changed the line endings back in a later commit in this PR.

Contributor

InfiniteLoop90 commented Sep 5, 2017

When looking at this pull request, you'll want to ignore whitespace. My IDE apparently changed the line endings and I didn't realize that until now. Sorry!

Nevermind! I changed the line endings back in a later commit in this PR.

InfiniteLoop90 added some commits Sep 5, 2017

Related to issue #724 - Also ensures that the ID is copied for HL7 DS…
…TU2 and DSTU2.1 subclasses of BackboneElement when the #copy() method is called. Also added unit tests for these and reverted the line endings of the HL7 DSTU2 and DSTU2.1 versions of the DomainResource class back to CRLF
@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Oct 8, 2017

Contributor

@jamesagnew this is ready for review. Thanks!

Contributor

InfiniteLoop90 commented Oct 8, 2017

@jamesagnew this is ready for review. Thanks!

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Oct 31, 2017

Owner

Looks awesome! Merging now

Owner

jamesagnew commented Oct 31, 2017

Looks awesome! Merging now

jamesagnew added a commit that referenced this pull request Oct 31, 2017

@jamesagnew jamesagnew merged commit c5b7fea into jamesagnew:master Oct 31, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment