New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Boot Starter #743

Merged
merged 2 commits into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@mouellet
Contributor

mouellet commented Sep 30, 2017

Provides spring-boot-starter with auto-configurations for Rest server,
Jpa server, FHIR Validation and clients.

Default configurations overridable by configuration properties and
rest-server customizer.

Add Spring Boot Starter
Provides spring-boot-starter with auto-configurations for Rest server,
Jpa server, FHIR Validation and clients.

Default configurations overridable by configuration properties and 
rest-server customizer.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Sep 30, 2017

Coverage Status

Coverage increased (+0.02%) to 81.694% when pulling 30c391d on mouellet:spring-boot-starter into 56a71f9 on jamesagnew:master.

coveralls commented Sep 30, 2017

Coverage Status

Coverage increased (+0.02%) to 81.694% when pulling 30c391d on mouellet:spring-boot-starter into 56a71f9 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Nov 13, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 13, 2017

Owner

Hi Mathieu, this is cool! Thanks for the contribution!

Merging it now. Note that I'm going to move it into example-projects/ within the root HAPI project just to keep things organized, but that's the only change. Hope that's ok.

Owner

jamesagnew commented Nov 13, 2017

Hi Mathieu, this is cool! Thanks for the contribution!

Merging it now. Note that I'm going to move it into example-projects/ within the root HAPI project just to keep things organized, but that's the only change. Hope that's ok.

@jamesagnew jamesagnew merged commit f2cab54 into jamesagnew:master Nov 13, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 13, 2017

Coverage Status

Coverage decreased (-0.01%) to 82.771% when pulling 85bc654 on mouellet:spring-boot-starter into 32a4a08 on jamesagnew:master.

coveralls commented Nov 13, 2017

Coverage Status

Coverage decreased (-0.01%) to 82.771% when pulling 85bc654 on mouellet:spring-boot-starter into 32a4a08 on jamesagnew:master.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 14, 2017

Owner

Hi @mouellet, FYI I ended up not moving anything into the examples directory, on further reflection it is very nicely organized already :)

I have one question for you, as I don't know Spring Boot very well. As a result of merging #747 in, I had to add this line to the JPA test to get it to work.

That property is going to be required by anyone who uses this and they aren't likely to want to change it. Is there any way of making this the default?

Owner

jamesagnew commented Nov 14, 2017

Hi @mouellet, FYI I ended up not moving anything into the examples directory, on further reflection it is very nicely organized already :)

I have one question for you, as I don't know Spring Boot very well. As a result of merging #747 in, I had to add this line to the JPA test to get it to work.

That property is going to be required by anyone who uses this and they aren't likely to want to change it. Is there any way of making this the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment