New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a client interceptor called AdditionalRequestHeadersInterceptor to add arbitrary HTTP headers to the client request #755

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@InfiniteLoop90
Contributor

InfiniteLoop90 commented Oct 11, 2017

@jamesagnew Feel free to merge this in if you feel like it'll be useful. You recommended that I open a PR for this here: https://groups.google.com/forum/#!topic/hapi-fhir/tu4l1ltQXco

I did notice that HAPI FHIR already has an interceptor called SimpleRequestHeaderInterceptor that is intended to add a single HTTP header to the request so functionality-wise, there is some slight overlap between the functionalities of the existing SimpleRequestHeaderInterceptor interceptor (which can add a single HTTP header) and the AdditionalRequestHeadersInterceptor interceptor (which can add multiple HTTP headers).

InfiniteLoop90 added some commits Oct 11, 2017

Added a client interceptor called AdditionalRequestHeadersInterceptor…
… to add arbitrary HTTP headers to the client request
Removed the throwing of NullPointerException from AdditionalRequestHe…
…adersInterceptor since that isn't common due to NullPointerException being a runtime exception
@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Oct 30, 2017

Contributor

@jamesagnew This is ready for review. Thanks!

Contributor

InfiniteLoop90 commented Oct 30, 2017

@jamesagnew This is ready for review. Thanks!

jamesagnew added a commit that referenced this pull request Nov 15, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 15, 2017

Owner

This is awesome, thanks for the PR! Merging now.

Owner

jamesagnew commented Nov 15, 2017

This is awesome, thanks for the PR! Merging now.

@jamesagnew jamesagnew merged commit d006a8e into jamesagnew:master Nov 15, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment