New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleteByUrl to respect InCompartment Authorization #756

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@alvinleonard

alvinleonard commented Oct 11, 2017

Moved the assignment of the resource to delete before the actual delete as it will be used by the authorization to determine if this resource is in the compartment.

Alvin Leonard added some commits Oct 11, 2017

Alvin Leonard
Fix deleteByUrl to respect InCompartment Authorization
Moved the assignment of the resource to delete before the actual delete as it will be used by the authorization to determine if this resource is in the compartment.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 11, 2017

Coverage Status

Coverage decreased (-0.005%) to 81.734% when pulling 2114dd7 on alvinleonard:751-fix-deletebyurl into 432c511 on jamesagnew:master.

coveralls commented Oct 11, 2017

Coverage Status

Coverage decreased (-0.005%) to 81.734% when pulling 2114dd7 on alvinleonard:751-fix-deletebyurl into 432c511 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Nov 23, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 23, 2017

Owner

Nice work, thanks! Merging now.

Owner

jamesagnew commented Nov 23, 2017

Nice work, thanks! Merging now.

@jamesagnew jamesagnew merged commit 3aebfb5 into jamesagnew:master Nov 23, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
coverage/coveralls Coverage decreased (-0.005%) to 81.734%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment