New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #764 to allow the AbstractJaxRsConformanceProvider to support the DSTU2_HL7ORG, DSTU2_1, and R4 FhirContexts #767

Merged
merged 4 commits into from Nov 23, 2017

Conversation

Projects
None yet
2 participants
@InfiniteLoop90
Contributor

InfiniteLoop90 commented Oct 22, 2017

Adds support for the DSTU2_HL7ORG, DSTU2_1, and R4 FhirContexts in AbstractJaxRsConformanceProvider

@InfiniteLoop90 InfiniteLoop90 changed the title from Fixes #764 to allow the AbstractJaxRsConformanceProvider to support the DSTU2_HL7ORG FhirContext to Fixes #764 to allow the AbstractJaxRsConformanceProvider to support the DSTU2_HL7ORG, DSTU2_1, and R4 FhirContexts Oct 22, 2017

@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Oct 22, 2017

Contributor

@jamesagnew This is ready for review.

Contributor

InfiniteLoop90 commented Oct 22, 2017

@jamesagnew This is ready for review.

Related to issue #764, changed the private conformanceDate method in …
…DSTU2_HL7ORG's ServerConformanceProvider to be consistent with the ServerConformanceProvider in other FHIR contexts
@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Nov 16, 2017

Contributor

It would be kind of nice if there could be a Conformance Provider class in each of the various resource structure modules. That way, the hapi-fhir-jaxrsserver-base module could have the dependencies on the resource structure modules marked as optional so that a project that pulls in the hapi-fhir-jaxrsserver-base artifact wouldn’t be forced to pull in all of the resource structures transitivily. But I think unfortunately breaking changes would be required to make that happen.

Contributor

InfiniteLoop90 commented Nov 16, 2017

It would be kind of nice if there could be a Conformance Provider class in each of the various resource structure modules. That way, the hapi-fhir-jaxrsserver-base module could have the dependencies on the resource structure modules marked as optional so that a project that pulls in the hapi-fhir-jaxrsserver-base artifact wouldn’t be forced to pull in all of the resource structures transitivily. But I think unfortunately breaking changes would be required to make that happen.

jamesagnew added a commit that referenced this pull request Nov 23, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 23, 2017

Owner

This looks great- merging now.

I'm not sure I understand your comment though:

It would be kind of nice if there could be a Conformance Provider class in each of the various resource structure modules.

There is a conformance provider in each structure module. E.g. this one for hl7org-dstu2. What am I missing?

Owner

jamesagnew commented Nov 23, 2017

This looks great- merging now.

I'm not sure I understand your comment though:

It would be kind of nice if there could be a Conformance Provider class in each of the various resource structure modules.

There is a conformance provider in each structure module. E.g. this one for hl7org-dstu2. What am I missing?

@jamesagnew jamesagnew merged commit ffc6724 into jamesagnew:master Nov 23, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment