New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Conformance providers in the hapi-fhir-jaxrsserver-example module to pass the server description, server name, and server version in the correct order #770

Merged
merged 2 commits into from Nov 23, 2017

Conversation

Projects
None yet
3 participants
@InfiniteLoop90
Contributor

InfiniteLoop90 commented Oct 24, 2017

I noticed when looking at the hapi-fhir-jaxrsserver-example that the server version, server name, and server description were being passed in the wrong order to the super constructor.

InfiniteLoop90 added some commits Oct 24, 2017

Fixed the Conformance providers in the hapi-fhir-jaxrsserver-example …
…module to pass the server description, server name, and server version in the correct order
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 24, 2017

Coverage Status

Coverage increased (+0.02%) to 81.861% when pulling 129340d on InfiniteLoop90:jaxrsserver-example-conformance-constructor-order into 5997594 on jamesagnew:master.

coveralls commented Oct 24, 2017

Coverage Status

Coverage increased (+0.02%) to 81.861% when pulling 129340d on InfiniteLoop90:jaxrsserver-example-conformance-constructor-order into 5997594 on jamesagnew:master.

@InfiniteLoop90

This comment has been minimized.

Show comment
Hide comment
@InfiniteLoop90

InfiniteLoop90 Oct 30, 2017

Contributor

@jamesagnew This is ready for review. Thanks!

Contributor

InfiniteLoop90 commented Oct 30, 2017

@jamesagnew This is ready for review. Thanks!

jamesagnew added a commit that referenced this pull request Nov 23, 2017

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Nov 23, 2017

Owner

Looks good, merging now!

Owner

jamesagnew commented Nov 23, 2017

Looks good, merging now!

@jamesagnew jamesagnew merged commit 079ba2c into jamesagnew:master Nov 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
coverage/coveralls Coverage increased (+0.02%) to 81.861%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment