New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure to use resourceType properly when it is explicitly provided in a chained reference param #786

Merged
merged 2 commits into from Mar 12, 2018

Conversation

Projects
None yet
3 participants
@CarthageKing

CarthageKing commented Nov 15, 2017

This PR ensures that when the resourceType is explicitly defined in the reference search parameter, that it gets used properly and also that the value also gets parsed properly.

Before this fix, specifying a search like Observation?subject:Patient.identifier=http://a.b/c/d|123, the 'Patient' resourceType would be overwritten with a path from the provided url value, and the value would be incorrect. This is due to the invocation of setValue(), which internally calls myId.setValue().

michael.i.calderero
@coveralls

This comment has been minimized.

coveralls commented Nov 15, 2017

Coverage Status

Coverage increased (+0.01%) to 82.797% when pulling b277693 on CarthageKing:bugfix-chaining-urlvalue into 6da0809 on jamesagnew:master.

jamesagnew added a commit that referenced this pull request Mar 12, 2018

@jamesagnew jamesagnew merged commit cb2f5a0 into jamesagnew:master Mar 12, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 12, 2018

Looks great, thanks for the PR!

@CarthageKing CarthageKing deleted the CarthageKing:bugfix-chaining-urlvalue branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment