New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch mapping for Jpa Server #798

Merged
merged 6 commits into from Mar 15, 2018

Conversation

Projects
None yet
3 participants
@JiajingLiang
Contributor

JiajingLiang commented Nov 27, 2017

This PR provides an implementation of ElasticSearch analysis definition for Fhir Jpa Server.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Dec 13, 2017

Hi @JiajingLiang - This is looking cool!

Should I wait for an example project before merging or are you planning that in a separate PR?

@JiajingLiang

This comment has been minimized.

Contributor

JiajingLiang commented Dec 14, 2017

Hi @jamesagnew, I'm working on the demo application and it's coming in several days. Please wait a little, otherwise people won't know how to use the integration with ElasticSearch. Thanks a lot.

@JiajingLiang

This comment has been minimized.

Contributor

JiajingLiang commented Dec 21, 2017

Hello @jamesagnew,
I added an example configuration class for the ElasticSearch integration, and a mini tutorial paragraph in ReadMe for explaining how to use it.

@storni

This comment has been minimized.

storni commented Jan 18, 2018

Hi @JiajingLiang, thanks for the instructions. Just a minor detail: in Hibernate 5.8.2.Final, the property name for ES analyzers is "hibernate.search.elasticsearch.analysis_definition_provider" ("analysis" instead of "analyzer")

See latest hibernate search docs

Regards.

@JiajingLiang

This comment has been minimized.

Contributor

JiajingLiang commented Jan 19, 2018

Hi @storni,
Thank you very much for the comment. I've also notice. But as the demo project use the Hibernate 5.7.1.Final, I use the property hibernate.search.elasticsearch.analyzer_definition_provider. Of course, if you use the Hibernate 5.8.2.Final, you should use property hibernate.search.elasticsearch.analysis_definition_provider

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 15, 2018

Super cool, merging now.

@jamesagnew jamesagnew merged commit 84e606c into jamesagnew:master Mar 15, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

jamesagnew added a commit that referenced this pull request Mar 15, 2018

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 15, 2018

Hi @JiajingLiang , I have replaced the hibernate.search.elasticsearch.analysis_definition_provider with a constant in order to hoipefully make it easier to catch the change when we upgrade hibernate search.

I have two questions:

  1. Are you interested in joining the project to continue maintaining this module on an ongoing basis?
  2. What could be done in the way of automated tests for this module? Is it possible to create an integration test that spawns an embedded ES instance to work against?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment