New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #809 where date search params get deleted upon resource update #810

Merged
merged 1 commit into from Dec 22, 2017

Conversation

Projects
None yet
2 participants
@darktyco
Contributor

darktyco commented Dec 22, 2017

The equals function in ResourceIndexedSearchParamDate doesn't work as expected when the Dates in a persistent entity are java.sql.Timestamp objects but the dates in a transient entity are java.util.Date objects. Given a pair of equivalent Date and Timestamp objects, Date.equals(Timestamp) will be true but Timestamp.equals(Date) will not be true.

Updating the equals and hashcode method to compare the underlying time value instead. Added tests.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Dec 22, 2017

Great catch, thanks! Merging now

@jamesagnew jamesagnew merged commit bf3c09f into jamesagnew:master Dec 22, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details

jamesagnew added a commit that referenced this pull request Dec 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment