New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to create a resthook subscription without returning a p… #812

Merged
merged 1 commit into from Mar 19, 2018

Conversation

Projects
None yet
3 participants
@javajeff
Collaborator

javajeff commented Dec 23, 2017

…ayload using an HTTP POST for notification

I removed a validation for a blank payload, removed setting a default payload, and added the ability to send a HTTP POST notification to the subscriber's server if there is no payload.

Added ability to create a resthook subscription without returning a p…
…ayload using an HTTP POST for notification
@coveralls

This comment has been minimized.

coveralls commented Dec 23, 2017

Coverage Status

Coverage decreased (-0.06%) to 72.346% when pulling eb2d21a on subscriptionsWithoutPayloadPOST into fe37c87 on master.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 19, 2018

Looks good, merging now!

@jamesagnew jamesagnew merged commit 3f6861e into master Mar 19, 2018

1 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage decreased (-0.06%) to 72.346%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jamesagnew added a commit that referenced this pull request Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment