New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of method chaining for DateRangeParameter #857

Merged
merged 2 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants
@Tastelezz

Tastelezz commented Feb 21, 2018

  • according to the design of most other IQueryParameterXXX implementations I changed the methods void setUpperBound() and DateRangeParam setLowerBound() to DateRangeParam setUpperBound() and void setLowerBound() supporting method chaining.
  • changed the order in which the state of a DateRangeParam instance got first modified and then verified.
  • renamed the private method validateAndThrowDataFormatExceptionIfInvalid() to validateAndSet(DateParam, DateParam).
  • replaced the methods boolean haveLowerBound() and boolean haveUpperBound() with the stateless method boolean hasBound(DateParam).
Gaetano Gallo
- according to the design of all other IQueryParameterXXX types chang…
…ed the methods setUpperBound() and setLowerBound() to return this, supporting method chaining.

- changed the order in which the state of a DateRangeParam instance got first modified and then verified.
- renamed the private method validateAndThrowDataFormatExceptionIfInvalid() to validateAndSet(DateParam, DateParam).
- replaced the methods haveLowerBound() and haveUpperBound() with the stateless method hasBound(DateParam).
@coveralls

This comment has been minimized.

coveralls commented Feb 21, 2018

Coverage Status

Coverage decreased (-0.01%) to 72.848% when pulling 01ff2e7 on Tastelezz:wip-DateRangeParam into 72cf22e on jamesagnew:master.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 23, 2018

Looks great! Thanks! Merging now.

@jamesagnew jamesagnew merged commit 148ec8e into jamesagnew:master May 23, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

jamesagnew added a commit that referenced this pull request May 23, 2018

@Tastelezz Tastelezz deleted the Tastelezz:wip-DateRangeParam branch May 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment