New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

equals() and hashCode() for DateRangeParam and DateParam #868

Merged
merged 2 commits into from Mar 2, 2018

Conversation

Projects
None yet
3 participants
@Tastelezz

Tastelezz commented Feb 27, 2018

  • added guava-testlib as test dependency to modules hapi-fhir-structures-dstu2 and hapi-fhir-structures-dstu3
  • added DateRangeParam.equals(Object) and DateRangeParam.hashCode()
  • added DateParam.equals(Object) and DateParam.hashCode()
@Tastelezz

This comment has been minimized.

Tastelezz commented Feb 28, 2018

I added some test samples and wonder why on my machine the prefix APPROXIMATE matches but not on the CI? The error message is:

[ERROR] Failures: [ERROR] DateParamTest.testEqualsAndHashCode:129 DateParam[prefix=APPROXIMATE,value=2011-11-11T11:11:11.111-11:11] [group 5, item 1] must be Object#equals to DateParam[prefix=APPROXIMATE,value=2011-11-11T12:12:12.123-12:12] [group 5, item 2]

Any ideas? The second test sample is of no real importance, but I am curious why this happens, because I can't see how the prefix and the dates provided could depend on the execution environment.

Gaetano Gallo
- added guava-testlib as test dependency to modules hapi-fhir-structu…
…res-dstu2 and hapi-fhir-structures-dstu3

- added DateRangeParam.equals(Object) and DateRangeParam.hashCode()
- fixed broken DateParamTest
@coveralls

This comment has been minimized.

coveralls commented Mar 2, 2018

Coverage Status

Coverage increased (+0.02%) to 72.958% when pulling 3009ec7 on Tastelezz:wip-DateParam into 8ebf084 on jamesagnew:master.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 2, 2018

Might have been a fluke or something.. Looks like it's passing now.

jamesagnew added a commit that referenced this pull request Mar 2, 2018

@jamesagnew jamesagnew merged commit fe140a5 into jamesagnew:master Mar 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 72.958%
Details
@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 2, 2018

Thanks for the contribution! It has been merged.

@Tastelezz Tastelezz deleted the Tastelezz:wip-DateParam branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment