New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement #826 - add OSGI support and Apache Karaf features with inte… #871

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
5 participants
@johnpoth
Collaborator

johnpoth commented Feb 28, 2018

…gration tests

This PR is part of #826 which adds OSGI support and Apache Karaf features for the HAPI-FHIR project.

This PR adds OSGI support for:

  • HAPI-FHIR structures DSTU2, HL7ORGDSTU2, DSTU2.1, DSTU3, R4
  • HAPI-FHIR Resource validation DSTU2, HL7ORGDSTU2, DSTU2.1, DSTU3, R4
  • Apache Karaf features for all the above
  • Integration Tests

What remains to do is:

  • HAPI-FHIR Server support
  • HAPI-FHIR narrative support. This might be tricky as Thymeleaf doesn't support OSGi.
  • Any other features that I've missed :)

Thanks!

@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2018

Coverage Status

Coverage decreased (-0.03%) to 72.913% when pulling 66ebfa0 on johnpoth:hapi-fhir-osgi into 2eee606 on jamesagnew:master.

@johnpoth

This comment has been minimized.

Collaborator

johnpoth commented Mar 15, 2018

@jamesagnew bump :)

@splatch

This comment has been minimized.

Contributor

splatch commented Mar 23, 2018

@johnpoth hey, this PR is quite interesting for me as I am Karaf commiter and I work with HAPI these days. I will be able to test it with my OSGi based deployment which is (luckily) free of Hibernate.

@johnpoth

This comment has been minimized.

Collaborator

johnpoth commented Mar 26, 2018

@splatch that's great! I just added a commit that adds OSGI support for hapi-fhir-client

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 27, 2018

Very cool, looks great! I'm going to merge this now.

One note, I'm going to move the new modules into a directory called osgi because the repo is getting massive and I'm trying to organize it a bit. Hopefully that doesn't cause any issues.

@jamesagnew jamesagnew merged commit b56d65e into jamesagnew:master Mar 27, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

jamesagnew added a commit that referenced this pull request Mar 27, 2018

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 27, 2018

@johnpoth This file has a classname that doesn't match the file name. I had to delete it to get the build to pass. Would you mind to have a look?

@johnpoth johnpoth deleted the johnpoth:hapi-fhir-osgi branch Mar 27, 2018

@splatch

This comment has been minimized.

Contributor

splatch commented Mar 27, 2018

Hey James,
I been on it and fixed compile error locally. Feel free to pull deleted file from #905.

Cheers,
Lukasz

@johnpoth

This comment has been minimized.

Collaborator

johnpoth commented Mar 27, 2018

Thanks @jamesagnew for merging! Looks like I didn't run 'git add' on some changes on my last commit.

#906 updates that, @splatch please update as well.

Thanks!

@anthonys123

This comment has been minimized.

Contributor

anthonys123 commented May 8, 2018

Hi John/Lukasz - I'm trying to debug the latest 3.4.0 master version of the JPA Server in IntelliJ Ultimate and am encountering some OSGi-related build errors shown in the screenshot below. A Maven build from the Command Prompt works fine. Would you have any ideas what is happening here?

ArrayIndexOutOfBoundsExceptions being thrown by the DSAnnotations and MetatypeAnnotations plug-ins. Is bnd being used for the OSGi packaging?

untitled

@splatch

This comment has been minimized.

Contributor

splatch commented May 8, 2018

@anthonys123 - just remove OSGI facet from project and you will be fine. Best - disable it permanently.
If you run maven build from inside of IntelliJ, make sure you use maven 3.5+, and best - try using external installation instead of one embedded by jetbrains.

@anthonys123

This comment has been minimized.

Contributor

anthonys123 commented May 8, 2018

Many thanks Lukasz for the quick reply. That fixed it.

@anthonys123

This comment has been minimized.

Contributor

anthonys123 commented May 8, 2018

Lukasz - I'm curious, is this an interaction issue between IntelliJ and the OSGi framework? Should I log an issue about this?

@splatch

This comment has been minimized.

Contributor

splatch commented May 8, 2018

It's IDE error at this stage. You don't run OSGi framework at this point but your developer tool attempts to warn you about things which could happen in runtime by enforcing some checks while you work.
Main problem is that IntelliJ doesn't really support manifests generated from maven plugin. That's why it tends to fail big time on every project which does not follow their way.

@anthonys123

This comment has been minimized.

Contributor

anthonys123 commented May 8, 2018

Understood - thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment