New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation server exception when local reference absent #874

Merged
merged 3 commits into from May 23, 2018

Conversation

Projects
None yet
3 participants
@hdconradi

hdconradi commented Mar 1, 2018

Currently an invalid local reference causes an InternalErrorException caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error message.

This pull request fixes this error by allowing fetcher==null in case of local references.

Unfortunately, there are now two error messages with the same meaning:

  • one from the ProfileValidation
  • one from the code in this location.
@coveralls

This comment has been minimized.

coveralls commented Mar 1, 2018

Coverage Status

Coverage increased (+0.01%) to 72.524% when pulling b2107ba on hdconradi:validation-server-exception-when-local-reference-absent into f766156 on jamesagnew:master.

darktyco added a commit to darktyco/hapi-fhir that referenced this pull request Mar 6, 2018

@hdconradi

This comment has been minimized.

hdconradi commented Mar 7, 2018

Rebased to the state after the R4 sync.

Heinz-Dieter Conradi added some commits Feb 28, 2018

Heinz-Dieter Conradi Heinz-Dieter Conradi
Add test for invalid local reference (DSTU3)
Currently an invalid local reference causes an InternalErrorException
caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error
message.
Heinz-Dieter Conradi Heinz-Dieter Conradi
Add test for invalid local reference (R4)
Currently an invalid local reference causes an InternalErrorException
caused by: FHIRException: Resource resolution services not provided.
The validation should instead return normally and contain an error
message.
Heinz-Dieter Conradi Heinz-Dieter Conradi
Fix the server exception when validating an invalid local reference
'fetcher == null' is ok for a local reference.

Unfortunately, there are now two messages with the same meaning:
- one from the ProfileValidation
- one from the code in this location
@hdconradi

This comment has been minimized.

hdconradi commented Apr 3, 2018

Rebased after 3.3

@jamesagnew jamesagnew merged commit eb77b8a into jamesagnew:master May 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 72.524%
Details

jamesagnew added a commit that referenced this pull request May 23, 2018

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented May 23, 2018

Thanks for the PR! This looks great.

It has been merged and synced upstream.

@hdconradi hdconradi deleted the hdconradi:validation-server-exception-when-local-reference-absent branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment