New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #878 where resources in a bundle are updated even when no… #879

Merged
merged 1 commit into from Mar 22, 2018

Conversation

Projects
None yet
2 participants
@darktyco
Contributor

darktyco commented Mar 6, 2018

… data changes.

It looks like the issue is being caused by a misconfigured element exclusion list that is passed to the parser. "meta" was being passed in but the parser actually looks for "<resource_type>.meta" or "*.meta" when checking if it should serialize the meta block (see "shouldEncodeResourceMeta" in BaseParser.java). Updating the meta element to *.meta so the meta block will be excluded for all resource types resolves the issue.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 6, 2018

Great catch! Will merge this for sure before the March release.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 22, 2018

Looks great, merging now!

@jamesagnew jamesagnew merged commit b89e0e7 into jamesagnew:master Mar 22, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 73.026%
Details

jamesagnew added a commit that referenced this pull request Mar 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment