New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text items in questionnaire #892

Merged
merged 3 commits into from May 24, 2018

Conversation

Projects
None yet
3 participants
@hdconradi

hdconradi commented Mar 20, 2018

Currently it is not possible to have a validated QuestionnaireResponse for a Questionnaire with a text item:
According to the specification (https://www.hl7.org/fhir/valueset-item-type.html, or the current version http://build.fhir.org/valueset-item-type.html), the answer has to be a valueString. The InstanceValidator does currently not validate such a request and insists that the answer has to be a 'text'.

This patch-set contains two patches with add tests for all item types for both DSTU3 and R4.
The other patch fixes the issue by adapting the value to compare against.

Furthermore, the patches fix a NPE which I stumbled against when creating the test. Unfortunately, I did forget to record the exact circumstances.

@coveralls

This comment has been minimized.

coveralls commented Mar 20, 2018

Coverage Status

Coverage increased (+0.02%) to 72.533% when pulling 01b84cd on hdconradi:validate-questionnaire-response-item-type-for-text into f766156 on jamesagnew:master.

@hdconradi

This comment has been minimized.

hdconradi commented Apr 3, 2018

Rebased after 3.3

@jamesagnew jamesagnew merged commit 1ead3f7 into jamesagnew:master May 24, 2018

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls Coverage increased (+0.02%) to 72.533%
Details

jamesagnew added a commit that referenced this pull request May 24, 2018

@hdconradi hdconradi deleted the hdconradi:validate-questionnaire-response-item-type-for-text branch Jun 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment