New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #972 Update Spring Data 1.11.6.RELEASE to 2.0.7.RELEASE #974

Merged
merged 2 commits into from Jun 3, 2018

Conversation

Projects
None yet
3 participants
@Romanow88
Contributor

Romanow88 commented May 31, 2018

I was not sure what to do with the orElse part of the Optional that Spring Data now returns for .findBy... , so I used a simple IllegalStateException. If you think we should use something else - let me know.

@Romanow88

This comment has been minimized.

Show comment
Hide comment
@Romanow88

Romanow88 May 31, 2018

Contributor

travis build failed on ResourceProviderInterceptorR4Test.testCreateConditionalNoOpResourceInTransaction, but appveyor executed it successfully. Is that a flaky test?

Contributor

Romanow88 commented May 31, 2018

travis build failed on ResourceProviderInterceptorR4Test.testCreateConditionalNoOpResourceInTransaction, but appveyor executed it successfully. Is that a flaky test?

@Romanow88

This comment has been minimized.

Show comment
Hide comment
@Romanow88

Romanow88 May 31, 2018

Contributor

@jamesagnew is the CI valid? One failed with a test that the second one passed only to fail on another.

Running the build locally produces a success.

Contributor

Romanow88 commented May 31, 2018

@jamesagnew is the CI valid? One failed with a test that the second one passed only to fail on another.

Running the build locally produces a success.

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Jun 1, 2018

Owner

No, the CI is in a bad state right now due to HAPI's build being so big that it regularly fails for no good reason on both Travis and Appveyor. I'll be landing the java9 branch ASAP which gets it back in good state.

Owner

jamesagnew commented Jun 1, 2018

No, the CI is in a bad state right now due to HAPI's build being so big that it regularly fails for no good reason on both Travis and Appveyor. I'll be landing the java9 branch ASAP which gets it back in good state.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jun 2, 2018

Coverage Status

Coverage increased (+0.003%) to 72.652% when pulling 8f1effe on Romanow88:master into fedf4a8 on jamesagnew:master.

coveralls commented Jun 2, 2018

Coverage Status

Coverage increased (+0.003%) to 72.652% when pulling 8f1effe on Romanow88:master into fedf4a8 on jamesagnew:master.

@jamesagnew jamesagnew merged commit e36bc38 into jamesagnew:master Jun 3, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 72.652%
Details

jamesagnew added a commit that referenced this pull request Jun 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment