New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes regarding behavior for Prefer header #996

Merged
merged 4 commits into from Jul 30, 2018

Conversation

Projects
None yet
2 participants
@anamariaradu10
Contributor

anamariaradu10 commented Jun 12, 2018

Hello,

While working with FHIR in a project, I discovered that the behavior for the Prefer header in the request is different to the one explained in the documentation from https://www.hl7.org/fhir/http.html.

What is currently happening:
Prefer: return=minimal --> returns the OperationOutcome
Prefer: return=representation --> returns full resource
Prefer: return=OperationOutcome --> returns the OperationOutcome
no Prefer header supplied --> returns the OperationOutcome

What is explained in the documentation:
Prefer: return=minimal --> returns no body
Prefer: return=representation --> returns full resource
Prefer: return=OperationOutcome --> returns an OperationOutcome
If no value is supplied --> "In the absence of the header, servers may choose whether to return the full resource or not (but not the OperationOutcome; that should only be returned if explicitly requested)"

Therefore, I submit this pull request as a proposal to make the behavior to be as the one stated in the documentation.

Thank you,
Ana Maria Radu

anamariaradu10 added some commits Jun 12, 2018

In my opinion these changes should be made in order to have the behavior
for the Prefer header values as the one explained in the official
documentation from https://www.hl7.org/fhir/http.html

jamesagnew added a commit that referenced this pull request Jul 30, 2018

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Jul 30, 2018

Owner

Hi @anamariaradu10 , this looks awesome, thanks for the pull request!

Merging it now. Please let me know if there are any additional details you'd like to add for the contributors section. (See: 17a9763 )

Owner

jamesagnew commented Jul 30, 2018

Hi @anamariaradu10 , this looks awesome, thanks for the pull request!

Merging it now. Please let me know if there are any additional details you'd like to add for the contributors section. (See: 17a9763 )

@jamesagnew jamesagnew merged commit db0f082 into jamesagnew:master Jul 30, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@anamariaradu10

This comment has been minimized.

Show comment
Hide comment
@anamariaradu10

anamariaradu10 Jul 30, 2018

Contributor

Hello @jamesagnew ,

Thank you for your response. For the contributors section I would like you to add Cerner Corporation as organization.

Contributor

anamariaradu10 commented Jul 30, 2018

Hello @jamesagnew ,

Thank you for your response. For the contributors section I would like you to add Cerner Corporation as organization.

jamesagnew added a commit that referenced this pull request Jul 30, 2018

@jamesagnew

This comment has been minimized.

Show comment
Hide comment
@jamesagnew

jamesagnew Jul 30, 2018

Owner

Done. :)

Owner

jamesagnew commented Jul 30, 2018

Done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment