New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public API for container / registry functions. #336

Merged
merged 2 commits into from Nov 17, 2015

Conversation

Projects
None yet
2 participants
@rwjblue
Contributor

rwjblue commented Nov 14, 2015

As of Ember 2.3, using this.container from within an instance that is looked up from the container will issue a deprecation warning suggesting that you should refactor away from the private this.container usage to the new public API for using container/registry features (Ember.getOwner(this)).

This change pulls in the ember-getowner-polyfill to allow us to use getOwner on all Ember versions (tested back to 1.10 in that addon's CI).

rwjblue added some commits Nov 14, 2015

Use public API for container / registry functions.
As of Ember 2.3, using `this.container` from within an instance that is
looked up from the container will issue a deprecation warning suggesting
that you should refactor away from the private `this.container` usage to
the new public API for using container/registry features
(`Ember.getOwner(this)`).

This change pulls in the `ember-getowner-polyfill` to allow us to use
`getOwner` on all Ember versions (tested back to 1.10 in that addon's
CI).
Lock ember-cli to 1.13.8.
IMHO, the addon should be updated to 1.13.12 in a separate PR.

@rwjblue rwjblue referenced this pull request Nov 14, 2015

Closed

ember-container-inject-owner - Checklist #12555

8 of 8 tasks complete
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 14, 2015

Contributor

I noticed that Ember 2.0 wasn't under CI so I submitted #337 with some ember-try config cleanup.

Contributor

rwjblue commented Nov 14, 2015

I noticed that Ember 2.0 wasn't under CI so I submitted #337 with some ember-try config cleanup.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 17, 2015

Contributor

Ember 2.3.0-beta.1 has been released, and anyone using ember-i18n prior to this PR will be receiving deprecations.

Contributor

rwjblue commented Nov 17, 2015

Ember 2.3.0-beta.1 has been released, and anyone using ember-i18n prior to this PR will be receiving deprecations.

@jamesarosen

This comment has been minimized.

Show comment
Hide comment
@jamesarosen
Owner

jamesarosen commented Nov 17, 2015

+1

jamesarosen added a commit that referenced this pull request Nov 17, 2015

Merge pull request #336 from rwjblue/avoid-deprecations-for-container
Use public API for container / registry functions.

@jamesarosen jamesarosen merged commit 2233786 into jamesarosen:master Nov 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment