Skip to content

Drop pre-compute of bases and phase #47

Closed
jamescasbon opened this Issue Jun 11, 2012 · 2 comments

2 participants

@jamescasbon
Owner

Please see branch 'performance'.

I have made a number of tweaks which result in 37% faster parsing of the 1kg VCF (see vcf/test/prof.py).

The breaking change is that most of the time is spent precomputing these. @arq5x this was your change, are you bothered if it goes?

@jamescasbon
Owner

in 0.4.6

@arq5x
arq5x commented Jun 12, 2012

Hi James,
I think this makes sense in the interest of a more broadly useful API. I will need to keep the pre-computation in my fork because of my use case (I need these values for every variant, so pre-computing actually saves me time).
Aaron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.