Add dependency on collections.Counter implementation for Python 2.6 #133

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
2 participants
Collaborator

martijnvermaat commented Dec 3, 2013

As per my suggestion in PR jamescasbon#131, defaultdict(int) was changed to Counter(). However, I didn't realize it was only added in Python 2.7 and we target Python 2.6.

This approach follows what we already did for collections.OrderedDict.

@jamescasbon, do you agree?

@martijnvermaat martijnvermaat Add dependency on collections.Counter implementation for Python 2.6
As per my suggestion in PR jamescasbon#131, defaultdict(int) was changed
to Counter(). However, I didn't realize it was only added in Python 2.7
and we target Python 2.6.

This approach follows what we already did for collections.OrderedDict.
226f56a
Owner

jamescasbon commented Dec 3, 2013

Seems ok to me

@jamescasbon jamescasbon added a commit that referenced this pull request Dec 3, 2013

@jamescasbon jamescasbon Merge pull request #133 from martijnvermaat/counter-python2.6
Add dependency on collections.Counter implementation for Python 2.6
7dc48c0

@jamescasbon jamescasbon merged commit 7dc48c0 into jamescasbon:master Dec 3, 2013

@gotgenes gotgenes pushed a commit to gotgenes/PyVCF that referenced this pull request May 13, 2014

@jamescasbon jamescasbon Merge pull request #133 from martijnvermaat/counter-python2.6
Add dependency on collections.Counter implementation for Python 2.6
1e5ac0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment