Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Correctly format contig output lines from writer, making output VCFs compatible with GATK. Fixes #74 #81

Merged
merged 1 commit into from Jan 2, 2013

Conversation

Projects
None yet
2 participants

This is a fix for issue 74:

#74

The raw dictionary output of PyVCF on contig lines causes errors if you process files downstream with GATK. This pull request detects and correctly formats "##contig" metadata. Includes an added test case to avoid regression.

@jamescasbon jamescasbon pushed a commit that referenced this pull request Jan 2, 2013

James Casbon Merge pull request #81 from chapmanb/master
Correctly format contig output lines from writer, making output VCFs compatible with GATK. Fixes #74
9ca7798

@jamescasbon jamescasbon merged commit 9ca7798 into jamescasbon:master Jan 2, 2013

@martijnvermaat martijnvermaat added a commit to martijnvermaat/PyVCF that referenced this pull request Jan 10, 2013

@martijnvermaat martijnvermaat Correctly write meta lines with dictionary value
Write meta lines with a dictionary-like value as

    ##meta=<field=value,field=value,...>

instead of as the Python dictionary string representation. This is a
fix for jamescasbon#83 and a generalization of jamescasbon#81. A
regression compared to jamescasbon#81 is that the order of fields in
a `contig` line is no longer defined.
9d43fa9

@gotgenes gotgenes pushed a commit to gotgenes/PyVCF that referenced this pull request May 13, 2014

James Casbon Merge pull request #81 from chapmanb/master
Correctly format contig output lines from writer, making output VCFs compatible with GATK. Fixes #74
0292557

@gotgenes gotgenes pushed a commit to gotgenes/PyVCF that referenced this pull request May 13, 2014

@martijnvermaat martijnvermaat Correctly write meta lines with dictionary value
Write meta lines with a dictionary-like value as

    ##meta=<field=value,field=value,...>

instead of as the Python dictionary string representation. This is a
fix for jamescasbon#83 and a generalization of jamescasbon#81. A
regression compared to jamescasbon#81 is that the order of fields in
a `contig` line is no longer defined.
dc1a367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment