Make twitter dependencies optional #282

Closed
bric3 opened this Issue Sep 9, 2016 · 4 comments

Projects

None yet

2 participants

@bric3
bric3 commented Sep 9, 2016 edited

3.10 introduces native SSL, however if we are not interested, the mockserver-core declares twitter artifacts and we happen to download the whole twitter finagle stack including scala.

I think the code could be loaded lazily, e.g. reflection.

This maybe doable for other dependencies, but I didn't check

@bric3
bric3 commented Sep 9, 2016

For reference here's the mvn dependency:tree

[INFO] +- org.mock-server:mockserver-netty:jar:3.10.4:test
[INFO] |  +- org.mock-server:mockserver-client-java:jar:3.10.4:test
[INFO] |  +- org.mock-server:mockserver-core:jar:3.10.4:test
[INFO] |  |  +- javax.servlet:javax.servlet-api:jar:3.0.1:provided
[INFO] |  |  +- io.netty:netty-codec-socks:jar:4.0.34.Final:test
[INFO] |  |  +- com.twitter:finagle-native_2.11:jar:6.33.0:test
[INFO] |  |  |  +- org.scala-lang:scala-library:jar:2.11.7:test
[INFO] |  |  |  +- com.twitter:finagle-core_2.11:jar:6.33.0:test
[INFO] |  |  |  |  +- com.twitter:util-app_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-cache_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-codec_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-collection_2.11:jar:6.32.0:test
[INFO] |  |  |  |  |  +- javax.inject:javax.inject:jar:1:test
[INFO] |  |  |  |  |  \- commons-collections:commons-collections:jar:3.2.2:test
[INFO] |  |  |  |  +- com.twitter:util-core_2.11:jar:6.32.0:test
[INFO] |  |  |  |  |  +- com.twitter:util-function_2.11:jar:6.32.0:test
[INFO] |  |  |  |  |  \- org.scala-lang.modules:scala-parser-combinators_2.11:jar:1.0.4:test
[INFO] |  |  |  |  +- com.twitter:util-hashing_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-jvm_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-lint_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-logging_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-registry_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:util-stats_2.11:jar:6.32.0:test
[INFO] |  |  |  |  +- com.twitter:jsr166e:jar:1.0.0:test
[INFO] |  |  |  |  \- io.netty:netty:jar:3.10.1.Final:test
[INFO] |  |  |  \- com.twitter:finagle-http_2.11:jar:6.33.0:test
[INFO] |  |  |     \- commons-lang:commons-lang:jar:2.6:test
[INFO] |  |  +- com.jcraft:jzlib:jar:1.1.3:test
[INFO] |  |  +- org.bouncycastle:bcmail-jdk15on:jar:1.52:test
[INFO] |  |  +- org.bouncycastle:bcpkix-jdk15on:jar:1.52:test
[INFO] |  |  +- org.skyscreamer:jsonassert:jar:1.2.3:test
[INFO] |  |  |  \- org.json:json:jar:20090211:test
[INFO] |  |  +- com.github.fge:json-schema-validator:jar:2.2.6:test
[INFO] |  |  |  +- com.google.code.findbugs:jsr305:jar:3.0.0:test
[INFO] |  |  |  +- com.github.fge:json-schema-core:jar:1.2.5:test
[INFO] |  |  |  |  +- com.github.fge:uri-template:jar:0.9:test
[INFO] |  |  |  |  |  \- com.github.fge:msg-simple:jar:1.1:test
[INFO] |  |  |  |  |     \- com.github.fge:btf:jar:1.2:test
[INFO] |  |  |  |  +- com.github.fge:jackson-coreutils:jar:1.8:test
[INFO] |  |  |  |  \- org.mozilla:rhino:jar:1.7R4:test
[INFO] |  |  |  +- javax.mail:mailapi:jar:1.4.3:test
[INFO] |  |  |  |  \- javax.activation:activation:jar:1.1:test
[INFO] |  |  |  \- net.sf.jopt-simple:jopt-simple:jar:4.6:test
[INFO] |  |  \- xerces:xercesImpl:jar:2.4.0:test
[INFO] |  +- io.netty:netty-buffer:jar:4.0.34.Final:test
[INFO] |  +- io.netty:netty-codec:jar:4.0.34.Final:test
[INFO] |  +- io.netty:netty-codec-http:jar:4.0.34.Final:test
[INFO] |  +- io.netty:netty-common:jar:4.0.34.Final:test
[INFO] |  +- io.netty:netty-handler:jar:4.0.34.Final:test
[INFO] |  +- io.netty:netty-transport:jar:4.0.34.Final:test
[INFO] |  +- org.bouncycastle:bcprov-jdk15on:jar:1.55:test
[INFO] |  +- janino:janino:jar:2.5.10:test
[INFO] |  \- org.mock-server:mockserver-logging:jar:3.10.4:test
@jamesdbloom
Owner

Yes I agree I'll remove all references to the native SSL code and solution as it was never really a good solid approach, if any work continues on this it should be on a branch until it works correctly.

@jamesdbloom
Owner

I have now removed the dependancy I will release a new version once one or two more bugs are fixed.

@bric3
bric3 commented Oct 12, 2016

@jamesdbloom thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment