New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net Standard 2.0 #27

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@nicolaiarocci
Copy link

nicolaiarocci commented Jan 18, 2018

This is a rather big change.

  • Net Standard 2.0
  • Update test project to new API version of xBehave (and update all dependencies to latest releases)
  • Drop the strong naming

Moving to Net Standard 2.0 implies dropping support for older .NET versions, such as 4.0, 4.5.x, and 4.6.0 (will do fine with 4.6.1+).

@SuperJMN

This comment has been minimized.

Copy link

SuperJMN commented Mar 1, 2018

Please, merge!

@SuperJMN

This comment has been minimized.

Copy link

SuperJMN commented Apr 2, 2018

@jamesfoster Are you there?

@ErikSchierboom

This comment has been minimized.

Copy link

ErikSchierboom commented Apr 30, 2018

This would be very convenient!

@dkmiller

This comment has been minimized.

Copy link

dkmiller commented Jun 11, 2018

Any reason this hasn't merged?

@nicolaiarocci

This comment has been minimized.

Copy link
Author

nicolaiarocci commented Jun 12, 2018

Given the strong demand, I could release from a fork. Not ideal, and I'd prefer to avoid that (besides, I'd be hard-pressed to find a better name than DeepEqual 😄 ).

@allrameest

This comment has been minimized.

Copy link
Contributor

allrameest commented Jul 26, 2018

@nicolaiarocci I think forking would be a good idea. I've tried emailing James but I didn't get an answer.
About the name... DeeperEqual? DeepestEqual? 😄

@SuperJMN

This comment has been minimized.

Copy link

SuperJMN commented Jul 26, 2018

I packaged it and posted (.NET Standard): https://www.nuget.org/packages/DeepEqual.SuperJMN/

@jamesfoster

This comment has been minimized.

Copy link
Owner

jamesfoster commented Dec 4, 2018

Apologies for the absence 🤕. Finally closing this. Version 1.7.1 is now multi-targeted to 4.6.2, standard 2.0, core 2.1

Thanks @SuperJMN for stepping up and helping out. Much appreciated.

@jamesfoster jamesfoster closed this Dec 4, 2018

@SuperJMN

This comment has been minimized.

Copy link

SuperJMN commented Dec 4, 2018

Thanks, @jamesfoster !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment