Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rigelhll.lua handling of multiple handshake inputs #74

Open
jameshegarty opened this issue Oct 13, 2017 · 2 comments
Open

rigelhll.lua handling of multiple handshake inputs #74

jameshegarty opened this issue Oct 13, 2017 · 2 comments

Comments

@jameshegarty
Copy link
Owner

rigelhll.lua doesn't seem to be handling multiple handshake inputs correctly.

We have to deal with:
mixed handshake and non-handshaked
N handshake inputs that get fanned-in to 1
N handshake inputs that do not get fanned in.

@jameshegarty
Copy link
Owner Author

  • note that this may be an instance where rigelhll needs bidirectional type solving... it won't know whether the N handshake inputs need to be fanned in, or concatenated, b/c this depends on what is downstream.

@jameshegarty
Copy link
Owner Author

It does need to deal with two cases:

  1. the module expects N streams (concat)
  2. the module expects 1 stream with N values (fan in)

This seems tractable. But if one of the inputs is static, this isn't going to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant