Skip to content

Commit

Permalink
sonar feedback.
Browse files Browse the repository at this point in the history
  • Loading branch information
jameshnsears committed Jan 28, 2019
1 parent 411e714 commit 5bb2b21
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/main/java/xqa/resources/XQueryResource.java
Expand Up @@ -6,7 +6,6 @@
import org.apache.commons.codec.digest.DigestUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.xml.sax.SAXException;
import xqa.api.xquery.XQueryRequest;
import xqa.api.xquery.XQueryResponse;
import xqa.commons.qpid.jms.MessageBroker;
Expand Down Expand Up @@ -42,7 +41,6 @@
import java.io.StringWriter;
import java.util.List;
import java.util.UUID;
import java.util.Vector;

@Path("/xquery")
@Consumes(MediaType.APPLICATION_JSON)
Expand Down Expand Up @@ -80,8 +78,7 @@ public XQueryResource(final MessageBrokerConfiguration messageBrokerConfiguratio
LOGGER.info(String.format("shardResponseSecondaryTimeout=%d", shardResponseSecondaryTimeout));

documentBuilderFactory = DocumentBuilderFactory.newInstance();
documentBuilderFactory.setFeature("http://xml.org/sax/features/external-general-entities", false);
documentBuilderFactory.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false);
documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
documentBuilderFactory.setXIncludeAware(false);
documentBuilderFactory.setExpandEntityReferences(false);

Expand All @@ -97,12 +94,12 @@ public XQueryResource(final MessageBrokerConfiguration messageBrokerConfiguratio
@POST
@Timed
public XQueryResponse xquery(final @NotNull @Valid XQueryRequest xquery)
throws JMSException, IOException, MessageBrokerException, TransformerException, SAXException { // json in
throws JMSException, IOException, MessageBrokerException, TransformerException { // json in
if (xquery.getXQueryRequest().isEmpty()) {
throw new WebApplicationException("no xquery", Response.Status.BAD_REQUEST);
}

List<Message> shardXQueryResponses = new Vector<>();
List<Message> shardXQueryResponses;

final String correlationId = UUID.randomUUID().toString();

Expand Down

0 comments on commit 5bb2b21

Please sign in to comment.