cargo install stork-search failing on wasm_bindgen syntax

[zerodat]

This is a build or install problem that happens on both:

• cargo 1.51.0 and rustc 1.51.0 on FreeBSD 12.2
• cargo 1.46.0 and rustc 1.47.0 on Ubuntu 20.04

Trying to install using cargo install stork-search fails with the following error:

error: expected `,`
  --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/stork-search-1.2.1/src/wasm.rs:38:35
   |
38 |     #[wasm_bindgen(js_namespace = console)]
   |                                   ^^^^^^^

error: aborting due to previous error

error: failed to compile `stork-search v1.2.1`, intermediate artifacts can be found at `/tmp/cargo-installRo2nch`

Oddly enough, if I instead clone the stork git repo, checkout v1.2.1, and build with cargo build, it works on both platforms.

[SoftwareDreamer]

I can confirm this, should look into this, it is annoying, the whole stork install process is a nightmare (wasted an hour) on Windows; WSL2 doesn't work (see error above), not everyone uses a Mac..

[jameslittle230]

@zerodat and @hkochniss - sorry you’re running into issues! I’ll do my best to make improvements here.

[Aethon]

I spent a couple hours behind this issue trying to get stork-search installed on an Alpine image. (Didn't seem like such a big deal, everything is hard to install on Alpine :P ) Anyway, long story short, I found this workaround that allowed to get it installed:

cargo install --git https://github.com/jameslittle230/stork.git  --tag v1.2.1 --locked

The --locked option is the key.
I haven't had time to look and see what version is floating and causing the grief, but I thought this info might help someone...

And while I am here, THANK YOU for this fantastic piece of software!

Currently running Cargo 1.56.0 and rustc 1.56.1 (via Rustup) on FreeBSD 13.0-RELEASE-p4, building stork-search as described per the installation instructions would fail also in the same manner as OP's.

I used @Aethon's workaround (bumping the tag to v1.3.0), and it worked for me. Thank you so much!

Stork is a breath of fresh air and much better to use than the old Tipue plugin needed for search functionality on Pelican sites. I hope that Stork gets better Linux support, a lot of people I know who are running Pelican on Linux aren't using Ubuntu and would love to have this on their sites. Perhaps in the future Stork could be distributed as a package? (Especially since it takes a lot of time to build...)

[jameslittle230]

Thanks for the kind words!

Honestly, I'd love to get better at distribution, but it's not one of my strengths as a software builder. Whenever I try to figure out how to get Stork published in more places, I get a little overwhelmed and decide to work on something with a better ROI¹. (Even on macOS, my "home turf" platform, I haven't been able to figure out how to get Homebrew to distribute a binary.)

If anyone reading this has spare cycles to help me get the Stork binary more easily distributed on the various package managers, I'd love to learn, help where I can, and eventually provide first-class binaries for all sorts of different targets. I recognize the importance, it's just... not something with which I'm particularly well-versed.

Footnotes

1. One of the reasons I wrote Stork in Rust in the first place was because the Rust ecosystem helps out so much with multiplatform installation. I've probably leaned on cargo install more than my fair share. :) ↩