Use Clap crate to parse command line commands #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaces argument parser with clap crate
—and then use it to get the value of the timing flag
—based on command line input vs. config file input. Choose command line if it’s available, otherwise choose config file if _it’s_ available, otherwise print an error to the console
—using old-style command-line interface
# Conflicts: # src/index_versions/v3/builder/fill_intermediate_entries.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
break_on_file_errorconfigfilenamein output configMy PR hygiene wasn't very good here. There's lots to test... I should come back and write more tests for all the small behavior changes I introduced here.